FindBugs Results

The following document contains the results of FindBugs.

Summary

FilesErrors
2641

Files

FilesViolations
org.dbforms.config.DbFormsErrors 1
org.dbforms.config.Error 2
org.dbforms.config.EventInfo 1
org.dbforms.config.Field 1
org.dbforms.config.FieldValue 2
org.dbforms.config.GrantedPrivileges 1
org.dbforms.config.Query 1
org.dbforms.config.ResultSetVector 1
org.dbforms.config.Table 2
org.dbforms.config.TableEvents 1
org.dbforms.devgui.ConfigFilePanel 2
org.dbforms.devgui.XMLConfigGenerator 2
org.dbforms.taglib.ConfTableDataTag 1
org.dbforms.taglib.DbBlobContentTag 1
org.dbforms.taglib.DbFormTag 3
org.dbforms.taglib.DbNavReloadButtonTag 1
org.dbforms.util.ServletUtil 1
org.dbforms.validation.DbFormsValidator 1
org.dbforms.validation.DbFormsValidatorUtil 2
org.dbforms.xmldb.FileSplitter 1
org.dbforms.taglib.cewolf.CewolfCategoryDataTag 1
org.dbforms.taglib.cewolf.CewolfHighLowSeriesDataTag$CewolfOHLCDataset 2
org.dbforms.event.datalist.dao.DataSourceJDBC 4
org.dbforms.event.datalist.dao.DataSourceXML 4
org.dbforms.util.MessageResources 1
org.dbforms.devgui.DevGui 1

org.dbforms.config.DbFormsErrors

ViolationLine
SBSC: Method org.dbforms.config.DbFormsErrors.insertParametersInString(String,String) concatenates strings using + in a loop 247

org.dbforms.config.Error

ViolationLine
EI2: org.dbforms.config.Error.setMessages(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org/dbforms/config/Error.messages 104
EI: org.dbforms.config.Error.getMessages() may expose internal representation by returning org.dbforms.config.Error.messages 114

org.dbforms.config.EventInfo

ViolationLine
SnVI: org.dbforms.config.EventInfo is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.Field

ViolationLine
SnVI: org.dbforms.config.Field is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.FieldValue

ViolationLine
Dm: org.dbforms.config.FieldValue.parseBOOLEAN(String) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead 627
SnVI: org.dbforms.config.FieldValue is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.GrantedPrivileges

ViolationLine
SnVI: org.dbforms.config.GrantedPrivileges is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.Query

ViolationLine
SnVI: org.dbforms.config.Query is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.ResultSetVector

ViolationLine
SnVI: org.dbforms.config.ResultSetVector is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.Table

ViolationLine
EI: org.dbforms.config.Table.getDefaultOrder() may expose internal representation by returning org.dbforms.config.Table.defaultOrder 247
SnVI: org.dbforms.config.Table is Serializable; consider declaring a serialVersionUID 0

org.dbforms.config.TableEvents

ViolationLine
SnVI: org.dbforms.config.TableEvents is Serializable; consider declaring a serialVersionUID 0

org.dbforms.devgui.ConfigFilePanel

ViolationLine
OS: org.dbforms.devgui.ConfigFilePanel.actionPerformed(java.awt.event.ActionEvent) may fail to close stream 251
ODR: org.dbforms.devgui.ConfigFilePanel.loadCatalogAndSchemaNames(java.awt.event.ActionEvent) may fail to close database resource 868

org.dbforms.devgui.XMLConfigGenerator

ViolationLine
ODR: org.dbforms.devgui.XMLConfigGenerator.createXMLOutput(ProjectData,boolean) may fail to close database resource 592
SBSC: Method org.dbforms.devgui.XMLConfigGenerator.createXMLOutput(ProjectData,boolean) concatenates strings using + in a loop 532

org.dbforms.taglib.ConfTableDataTag

ViolationLine
NP: Possible null pointer dereference in org.dbforms.taglib.ConfTableDataTag.fetchData(java.sql.Connection) 173

org.dbforms.taglib.DbBlobContentTag

ViolationLine
OS: org.dbforms.taglib.DbBlobContentTag.doEndTag() may fail to close stream 130

org.dbforms.taglib.DbFormTag

ViolationLine
EI2: org.dbforms.taglib.DbFormTag.setGotoHt(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org/dbforms/taglib/DbFormTag.gotoHt 517
EI: org.dbforms.taglib.DbFormTag.getGotoHt() may expose internal representation by returning org.dbforms.taglib.DbFormTag.gotoHt 526
SBSC: Method org.dbforms.taglib.DbFormTag.doStartTag() concatenates strings using + in a loop 1348

org.dbforms.taglib.DbNavReloadButtonTag

ViolationLine
UCF: Useless control flow in org.dbforms.taglib.DbNavReloadButtonTag.doStartTag() 92

org.dbforms.util.ServletUtil

ViolationLine
SBSC: Method org.dbforms.util.ServletUtil.addSpaces(int,String) concatenates strings using + in a loop 119

org.dbforms.validation.DbFormsValidator

ViolationLine
SnVI: org.dbforms.validation.DbFormsValidator is Serializable; consider declaring a serialVersionUID 0

org.dbforms.validation.DbFormsValidatorUtil

ViolationLine
SBSC: Method org.dbforms.validation.DbFormsValidatorUtil.getJavascript(java.util.List,java.util.Locale,java.util.Hashtable,org.apache.commons.validator.ValidatorResources,String,org.dbforms.config.DbFormsErrors) concatenates strings using + in a loop 264
SBSC: Method org.dbforms.validation.DbFormsValidatorUtil.getMessage(String,org.apache.commons.validator.ValidatorAction,java.util.Locale,org.apache.commons.validator.Field,org.dbforms.config.DbFormsErrors) concatenates strings using + in a loop 451

org.dbforms.xmldb.FileSplitter

ViolationLine
OS: org.dbforms.xmldb.FileSplitter.splitFile() may fail to close stream 89

org.dbforms.taglib.cewolf.CewolfCategoryDataTag

ViolationLine
Dm: org.dbforms.taglib.cewolf.CewolfCategoryDataTag.doEndTag() invokes dubious new String() constructor; just use "" 67

org.dbforms.taglib.cewolf.CewolfHighLowSeriesDataTag$CewolfOHLCDataset

ViolationLine
HE: org.dbforms.taglib.cewolf.CewolfHighLowSeriesDataTag$CewolfOHLCDataset defines equals but not hashCode 0
SIC: Should org.dbforms.taglib.cewolf.CewolfHighLowSeriesDataTag$CewolfOHLCDataset be a _static_ inner class? 0

org.dbforms.event.datalist.dao.DataSourceJDBC

ViolationLine
EI2: org.dbforms.event.datalist.dao.DataSourceJDBC.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceJDBC.filterConstraint 159
EI2: org.dbforms.event.datalist.dao.DataSourceJDBC.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceJDBC.orderConstraint 160
EI2: org.dbforms.event.datalist.dao.DataSourceJDBC.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceJDBC.sqlFilterParams 162
ODR: org.dbforms.event.datalist.dao.DataSourceJDBC.open() may fail to close database resource 523

org.dbforms.event.datalist.dao.DataSourceXML

ViolationLine
EI2: org.dbforms.event.datalist.dao.DataSourceXML.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceXML.filterConstraint 84
EI2: org.dbforms.event.datalist.dao.DataSourceXML.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceXML.orderConstraint 85
EI2: org.dbforms.event.datalist.dao.DataSourceXML.setSelect(org.dbforms.config.FieldValue[],org.dbforms.config.FieldValue[],String,org.dbforms.config.FieldValue[]) may expose internal representation by storing an externally mutable object into org/dbforms/event/datalist/dao/DataSourceXML.sqlFilterParams 87
UrF: Unread field: org.dbforms.event.datalist.dao.DataSourceXML.orderConstraint 0

org.dbforms.util.MessageResources

ViolationLine
MS: org.dbforms.util.MessageResources.LOCALE_KEY isn't final and can't be protected malicious code 0

org.dbforms.devgui.DevGui

ViolationLine
SS: Unread field: org.dbforms.devgui.DevGui.titleCore; should this field be static? 0